Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time spine move from dbt-utils to dbt-core #4263

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 12, 2023

Previews:

What are you changing in this pull request and why?

Closes: #4124

Move time_spine from dbt-utils to dbt-core

Uncomment if you're publishing docs for a prerelease version of dbt (delete if not applicable):

  • Add versioning components, as described in Versioning Docs

  • Add a note to the prerelease version Migration Guide

  • Review the Content style guide and About versioning so my content adheres to these guidelines.

  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 12, 2023 00:14
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 9:58pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Oct 12, 2023
@matthewshaver
Copy link
Contributor Author

@dbeatty10 can you tell me if this is an accurate way to represent this change?

@dbeatty10
Copy link
Contributor

@dbeatty10 can you tell me if this is an accurate way to represent this change?

Use dbt instead of dbt_core, and then you'll be good-to-go!

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will only work for dbt v1.7+

@Jstein77 or @QMalcolm do we need to preserve instructions the use dbt_utils.date_spine for dbt v1.6?

@QMalcolm
Copy link
Contributor

I think this will only work for dbt v1.7+

@Jstein77 or @QMalcolm do we need to preserve instructions the use dbt_utils.date_spine for dbt v1.6?

That is correct

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 12, 2023
@matthewshaver
Copy link
Contributor Author

I think this will only work for dbt v1.7+
@Jstein77 or @QMalcolm do we need to preserve instructions the use dbt_utils.date_spine for dbt v1.6?

That is correct

Corrected this based on the feedback here. Added version blocks

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver merged commit 70d50d4 into current Oct 12, 2023
6 checks passed
@matthewshaver matthewshaver deleted the time-spine branch October 12, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metricflow_time_spine creation documentation to use dbt-core macro (from dbt-core PR #8616)
4 participants