Use IEC standard abbreviation for mebibytes (MiB) #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 mebibyte = 1 MiB = 1024 * 1024 bytes 1 megabyte = 1 MB = 1000 * 1000 bytes
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
content
mirnawong1
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
hey @dbeatty10 great explanation and callout! thanks for opening this up to correct the docs and it's approved for you to merge ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Sing with me:
In computer worlds, sometimes units based on powers of 10 are used, and sometimes based on powers of 2 instead. I wouldn't go so far as to say this Wikipedia section is "easy" to read, but at least it's... something?
Long story short, the code here is clearly based on powers of 2, so the docs should say "MiB" instead of "MB".
1 mebibyte = 1 MiB = 1024 * 1024 bytes
1 megabyte = 1 MB = 1000 * 1000 bytes
Related to dbt-labs/dbt-core#7117
Checklist