Skip to content

Commit

Permalink
Merge branch 'current' into update-banner
Browse files Browse the repository at this point in the history
  • Loading branch information
mirnawong1 authored Oct 15, 2024
2 parents b92232b + 74273e2 commit 4970122
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 37 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/vale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ jobs:
separator: ' '
version: '2.27.0'

- name: Post summary comment
if: ${{ steps.changed-files.outputs.any_changed == 'true' }}
run: |
COMMENT="❗️Oh no, some Vale linting found issues! Please check the **Files change** tab for detailed results and make the necessary updates."
COMMENT+=$'\n'
COMMENT+=$'\n\n'
COMMENT+="➡️ Link to detailed report: [Files changed](${{ github.event.pull_request.html_url }}/files)"
gh pr comment ${{ github.event.pull_request.number }} --body "$COMMENT"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# - name: Post summary comment
# if: ${{ steps.changed-files.outputs.any_changed == 'true' }}
# run: |
# COMMENT="❗️Oh no, some Vale linting found issues! Please check the **Files change** tab for detailed results and make the necessary updates."
# COMMENT+=$'\n'
# COMMENT+=$'\n\n'
# COMMENT+="➡️ Link to detailed report: [Files changed](${{ github.event.pull_request.html_url }}/files)"
# gh pr comment ${{ github.event.pull_request.number }} --body "$COMMENT"
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
28 changes: 11 additions & 17 deletions styles/custom/LatinAbbreviations.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
# LatinAbbreviations.yml
extends: substitution
message: "Avoid latin abbreviations: '%s'. Consider using '%s' instead."
message: "Avoid Latin abbreviations: '%s'. Consider using '%s' instead."
level: warning
ignorecase: false

swap:
- e.g.: for example
- eg: for example
- e.g: for example
- i.e.: for example
- i.e.: that is
- etc.: and so on
- N.B.: Note

action:
name: replace
params:
- for example
- that is
- and so on
- Note
'e.g.': 'for example'
'e.g': 'for example'
'eg': 'for example'
'i.e.': 'that is'
'i.e': 'that is'
'etc.': 'and so on'
'etc': 'and so on'
'N.B.': 'Note'
'NB': 'Note'
8 changes: 0 additions & 8 deletions styles/custom/Metrics.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ Additionally, [`WARN_ERROR_OPTIONS`](/reference/global-configs/warnings) gives a
|--------------------------------|----------------------------------------------------|------------------------|
| `DeprecatedModel` | Parsing a project that defines a deprecated model | Producer |
| `DeprecatedReference` | Referencing a model with a past deprecation date | Producer and consumers |
| `UpcomingDeprecationReference` | Referencing a model with a future deprecation date | Producer and consumers |
| `UpcomingReferenceDeprecation` | Referencing a model with a future deprecation date | Producer and consumers |

** Example **

Example output for an `UpcomingDeprecationReference` warning:
Example output for an `UpcomingReferenceDeprecation` warning:
```
$ dbt parse
15:48:14 Running with dbt=1.6.0
Expand Down

0 comments on commit 4970122

Please sign in to comment.