Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix constraints enforcement rollover test #1041

Merged
merged 5 commits into from
May 10, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented May 8, 2024

resolves #1009

Problem

This test started failing. We skipped it to release and need to address the failure. We suspect there was a change with delta tables in Databricks that we're not properly accounting for.

Solution

  • unskip the test
  • update expected error messages to allow for ubuntu and macos versions

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 8, 2024
@mikealfare mikealfare requested a review from a team as a code owner May 8, 2024 19:56
@cla-bot cla-bot bot added the cla:yes label May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare marked this pull request as draft May 8, 2024 19:57
@mikealfare mikealfare marked this pull request as ready for review May 8, 2024 23:06
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label May 8, 2024
@mikealfare mikealfare marked this pull request as draft May 9, 2024 14:20
@mikealfare mikealfare marked this pull request as ready for review May 9, 2024 14:30
@mikealfare mikealfare merged commit 1f4442a into main May 10, 2024
20 checks passed
@mikealfare mikealfare deleted the bug/1009-constraints-enforcement-rollback branch May 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
2 participants