Demonstrate regression in dbt-core due to get_catalog updates (#8856) #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
commented
Oct 27, 2023
dev-requirements.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| # install latest changes in dbt-core | |||
| # TODO: how to automate switching from develop to version branches? | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter | |||
| git+https://github.com/dbt-labs/dbt-core.git@4122f6c308c88be4a24c1ea490802239a4c1abb8#egg=dbt-core&subdirectory=core | |||
There was a problem hiding this comment.
Revert the version of dbt-core to immediately prior to this PR: dbt-labs/dbt-core#8856.
|
Compare the CI checks here to a run against |
mikealfare
changed the title
5 tasks
mikealfare
commented
Oct 30, 2023
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter | ||
| # git+https://github.com/dbt-labs/dbt-core.git@4122f6c308c88be4a24c1ea490802239a4c1abb8#egg=dbt-core&subdirectory=core | ||
| # git+https://github.com/dbt-labs/dbt-core.git@4122f6c308c88be4a24c1ea490802239a4c1abb8#egg=dbt-tests-adapter&subdirectory=tests/adapter | ||
| git+https://github.com/dbt-labs/dbt-core.git@paw/filtered-catalog-casefold#egg=dbt-core&subdirectory=core |
There was a problem hiding this comment.
Point to the proposed fix on dbt-core to demonstrate it is working.
|
The issue has been resolved, this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A recent commit to
dbt-coreis causing inherited catalog tests to fail ondbt-snowflake.Solution
This PR does not fix the issue, but demonstrates the root cause.
Checklist