Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default python version for python models #1273

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #1203

Problem

We are defaulting to an EOL version of Python when the user does not specify a python version in their python models. This was missed because it is buried in the code.

Solution

  • Create a new settings module
    • Open to renaming, but we need to avoid things like config that get used everywhere
  • Update from Python 3.8 to Python 3.9 by referencing a new setting in the settings module

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 11, 2024
@mikealfare mikealfare requested a review from a team as a code owner December 11, 2024 22:10
@cla-bot cla-bot bot added the cla:yes label Dec 11, 2024
@mikealfare mikealfare enabled auto-merge (squash) December 13, 2024 21:35
@mikealfare mikealfare merged commit efc68e4 into main Dec 13, 2024
14 checks passed
@mikealfare mikealfare deleted the update-default-python-version-for-python-models branch December 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade py38 objects in Snowflake
2 participants