[Bug] Fix issue where dbt-snowflake
attempts to drop database roles during grants sync
#1188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1151
Problem
When the user provides a
grants
config and there is an existing database role with access to a model,dbt-snowflake
may attempt to revoke permissions on this database role.dbt-snowflake
does not manage database roles so the DDL that is produced is incorrect, resulting in an error. This bug shows up in particular for incremental models wheredbt-snowflake
attempts to reconcile permissions on a persistent object; normally tables/views are dropped and recreated so there is no need to revoke permissions.Solution
Remove database roles when standardizing the grants dict, as is done for
OWNERSHIP
permissions andSHARE
grants.Checklist