Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin macos test runners to macos-12 #71

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Pin macos test runners to macos-12 #71

merged 1 commit into from
Apr 25, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

macos-latest now points to macos-14-arm64; it used to point to macos-12. There is no py39 nor py38 on macos-14-arm64.

Solution

Pin to macos-12 for now and discuss long term options to use macos-14-arm64, and CI pinning in general.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 25, 2024
@mikealfare mikealfare requested a review from a team April 25, 2024 13:28
@mikealfare mikealfare merged commit 6a1897e into main Apr 25, 2024
15 of 18 checks passed
@mikealfare mikealfare deleted the pin-macos-runners branch April 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @emmyoop