Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dbt-core~=1.8.0a1 as convenience dep #44

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Add dbt-core~=1.8.0a1 as convenience dep #44

merged 4 commits into from
Apr 3, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We need to preserve backwards compatibility for installing this package.

Solution

Include dbt-core as a dependency for installation, but do not depend on it within functional code.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 3, 2024
@mikealfare mikealfare merged commit 5deb888 into main Apr 3, 2024
13 checks passed
@mikealfare mikealfare deleted the dependencies/add-core branch April 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt left review comments

Assignees

@mikealfare mikealfare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt