Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dummy file. #33

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add dummy file. #33

merged 1 commit into from
Mar 19, 2024

Conversation

VersusFacit
Copy link
Contributor

Dummy PR to get a testing PR up

@VersusFacit VersusFacit self-assigned this Mar 19, 2024
emmyoop
emmyoop approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is for now with the understanding that more PRs will follow on after testing since none of this can be tested before the workflow gets merged. Since this is a workflow that will be manually submitted there is little risk in this approach.

@mikealfare
Copy link
Contributor

Tests are failing here because we have not removed the dbt-core tests yet and they have fallen out of sync.

@mikealfare mikealfare merged commit 03e39d8 into main Mar 19, 2024
5 of 9 checks passed
@mikealfare mikealfare deleted the add_release_internal_workflow branch March 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees

@VersusFacit VersusFacit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VersusFacit @mikealfare @emmyoop