Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] Fix three unit tests without set_args, fix mock in test_graph.py #9897

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 12, 2024

Tidy first changes. 1) Add the set_args incantations to the three remaining unit tests without it. 2) Fix the test_graph.py mock of the HookParser reading of dbt_project.yml so it doesn't hang with pytest -s.

@gshank gshank added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Apr 12, 2024
@gshank gshank requested a review from a team as a code owner April 12, 2024 13:57
@cla-bot cla-bot bot added the cla:yes label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (c86cec3) to head (3e0043b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9897      +/-   ##
==========================================
- Coverage   88.14%   88.09%   -0.05%     
==========================================
  Files         178      178              
  Lines       22459    22459              
==========================================
- Hits        19797    19786      -11     
- Misses       2662     2673      +11     
Flag Coverage Δ
integration 85.46% <ø> (-0.13%) ⬇️
unit 61.82% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank merged commit 3c4456d into main Apr 12, 2024
68 checks passed
@gshank gshank deleted the unit_test_args branch April 12, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants