Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] Task config type #9874

Merged
merged 6 commits into from
Apr 10, 2024
Merged

[Tidy first] Task config type #9874

merged 6 commits into from
Apr 10, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Apr 8, 2024

Tidy first changes to add a type to "config" in the task hierarchy.

This involved moving a couple of things around because it had a badly constructed inheritance hierarchy, in which the base class did things that only applied to certain subclasses.

And of course, as usual when fixing mypy typing, it then started complaining about a couple of things which weren't all that related. Note that PackageContract and PackageSpec were the same Union, so I consolidated on PackageSpec.

@gshank gshank added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Apr 8, 2024
@gshank gshank requested a review from a team as a code owner April 8, 2024 15:13
@cla-bot cla-bot bot added the cla:yes label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 82.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 88.10%. Comparing base (b945d17) to head (e642580).
Report is 2 commits behind head on main.

Files Patch % Lines
core/dbt/task/base.py 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9874      +/-   ##
==========================================
+ Coverage   88.06%   88.10%   +0.04%     
==========================================
  Files         178      178              
  Lines       22457    22454       -3     
==========================================
+ Hits        19776    19784       +8     
+ Misses       2681     2670      -11     
Flag Coverage Δ
integration 85.47% <76.00%> (+0.05%) ⬆️
unit 61.87% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank merged commit a1f0057 into main Apr 10, 2024
62 checks passed
@gshank gshank deleted the task_config_type branch April 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants