Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query comments test #9861

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

damian3031
Copy link
Contributor

resolves #9860

Problem

test_query_comments.py::BaseMacroArgsQueryComments::test_matches_comment is comparing dbt-core version with dbt adapter version, which is wrong assumption after decoupling dbt adapters from dbt-core version.

Solution

Remove version comparison at, as it isn't related to query comment feature.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@damian3031 damian3031 requested a review from a team as a code owner April 5, 2024 15:14
@cla-bot cla-bot bot added the cla:yes label Apr 5, 2024
@github-actions github-actions bot added the community This PR is from a community member label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (ebc22fa) to head (fcc874a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9861      +/-   ##
==========================================
- Coverage   88.13%   88.07%   -0.06%     
==========================================
  Files         178      178              
  Lines       22449    22456       +7     
==========================================
- Hits        19785    19779       -6     
- Misses       2664     2677      +13     
Flag Coverage Δ
integration 85.44% <ø> (-0.13%) ⬇️
unit 61.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10 dbeatty10 added the Team:Adapters Issues designated for the adapter area of the code label Apr 5, 2024
@dbeatty10
Copy link
Contributor

Thanks for opening this PR @damian3031 !

A changelog entry isn't required for this one since the changes are local to the tests directory, but if you choose to add a changelog entry via changie new, then your contribution will also be credited within the changelog. Up to you either way!

@damian3031 damian3031 force-pushed the fix-query-comments-test branch from 8a03c5f to fcc874a Compare April 8, 2024 11:07
@damian3031
Copy link
Contributor Author

Hi @dbeatty10, I added changelog entry

@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Apr 8, 2024
@mikealfare mikealfare merged commit 668fe78 into dbt-labs:main Apr 17, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix query comments test
4 participants