Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.7] Fix Workflow Deprecations #9799

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 22, 2024

resolve dbt-labs/actions#137

Problem

Node 16 is EOL and we use it in our workflows

Solution

Upgrade to current action versions

Note: This is a simple backport because main has been fixed over multiple PRs over a long period of time. This PR should be able to be backported to previous versions though.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (947f397) to head (cbc9ee8).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest    #9799      +/-   ##
==============================================
- Coverage       86.70%   86.64%   -0.06%     
==============================================
  Files             179      179              
  Lines           26662    26662              
==============================================
- Hits            23116    23102      -14     
- Misses           3546     3560      +14     
Flag Coverage Δ
integration 83.47% <ø> (-0.13%) ⬇️
unit 65.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review March 22, 2024 16:30
@emmyoop emmyoop requested a review from a team as a code owner March 22, 2024 16:30
@emmyoop emmyoop requested a review from martynydbt March 22, 2024 16:33
@emmyoop emmyoop merged commit 2c24aa7 into 1.7.latest Apr 12, 2024
61 checks passed
@emmyoop emmyoop deleted the er/fix-workflow-deprecations branch April 12, 2024 14:40
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-9799-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-9799-to-1.6.latest.

@emmyoop emmyoop added backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest backport 1.4.latest labels Apr 12, 2024
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-9799-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-9799-to-1.5.latest.

Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-9799-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-9799-to-1.2.latest.

Copy link
Contributor

The backport to 1.1.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-9799-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latest

Then, create a pull request where the base branch is 1.1.latest and the compare/head branch is backport-9799-to-1.1.latest.

Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-9799-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-9799-to-1.0.latest.

Copy link
Contributor

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-9799-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-9799-to-1.4.latest.

Copy link
Contributor

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-9799-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c24aa79f0429f03af4c6eab2f3df89baf811675
# Push it to GitHub
git push --set-upstream origin backport-9799-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-9799-to-1.3.latest.

emmyoop added a commit that referenced this pull request Apr 12, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/workflows/main.yml
emmyoop added a commit that referenced this pull request Apr 12, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/actions/latest-wrangler/examples/example_workflow.yml
#	.github/workflows/main.yml
#	.github/workflows/model_performance.yml
#	.github/workflows/schema-check.yml
emmyoop added a commit that referenced this pull request Apr 12, 2024
emmyoop added a commit that referenced this pull request Apr 12, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/actions/latest-wrangler/examples/example_workflow.yml
#	.github/workflows/main.yml
#	.github/workflows/model_performance.yml
#	.github/workflows/schema-check.yml
emmyoop added a commit that referenced this pull request Apr 12, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/actions/latest-wrangler/examples/example_workflow.yml
#	.github/workflows/main.yml
#	.github/workflows/model_performance.yml
#	.github/workflows/schema-check.yml
emmyoop added a commit that referenced this pull request Apr 12, 2024
emmyoop added a commit that referenced this pull request Apr 12, 2024
emmyoop added a commit that referenced this pull request Apr 16, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/workflows/main.yml
emmyoop added a commit that referenced this pull request Apr 17, 2024
emmyoop added a commit that referenced this pull request Apr 17, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/actions/latest-wrangler/examples/example_workflow.yml
#	.github/workflows/main.yml
#	.github/workflows/model_performance.yml
#	.github/workflows/schema-check.yml
emmyoop added a commit that referenced this pull request Apr 17, 2024
* update to current node version

* remember codecov

* ensure uniquness in name

---------

Co-authored-by: Kshitij Aranke <[email protected]>
# Conflicts:
#	.github/actions/latest-wrangler/examples/example_workflow.yml
#	.github/workflows/main.yml
#	.github/workflows/model_performance.yml
#	.github/workflows/schema-check.yml
emmyoop added a commit that referenced this pull request Apr 17, 2024
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest backport 1.4.latest backport 1.5.latest backport 1.6.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants