Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate labeling PRs as community sourced #9797

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 22, 2024

resolves https://dbtlabs.atlassian.net/browse/OSS-3

Problem

GitHub doesn't have an easy way to filter out PRs that are created by the core/adapters team when tracking community PRs.

Solution

Add a special "community" label to PRs opened in non-draft or converted from draft to ready for review when the author is not on the core or adapters team

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (c6c0c79) to head (fce7263).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9797      +/-   ##
==========================================
- Coverage   88.09%   88.04%   -0.05%     
==========================================
  Files         178      178              
  Lines       22461    22461              
==========================================
- Hits        19787    19776      -11     
- Misses       2674     2685      +11     
Flag Coverage Δ
integration 85.42% <ø> (-0.13%) ⬇️
unit 61.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review March 22, 2024 15:08
@emmyoop emmyoop requested a review from a team as a code owner March 22, 2024 15:08
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Mar 22, 2024
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does other people use the label-community.yml? should we consider moving it to core repo?
The patch it self looks great!

@emmyoop
Copy link
Member Author

emmyoop commented Mar 22, 2024

@ChenyuLInx The meat of the logic already lives in dbt-labs/actions. The idea is adapters will also use it. However each repo needs to have their own copy like this one for permission purposes to be able to label the PRs and trigger at the right time.

@emmyoop emmyoop merged commit 58f9af7 into main Mar 22, 2024
59 checks passed
@emmyoop emmyoop deleted the er/add-community-label branch March 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants