-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug log when type_code
fails to convert to a data_type
#8957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main dbt-labs/dbt-core#8957 +/- ##
==========================================
- Coverage 86.49% 86.44% -0.06%
==========================================
Files 177 177
Lines 26405 26416 +11
==========================================
- Hits 22840 22834 -6
- Misses 3565 3582 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
dbeatty10
added
Team:Adapters
Issues designated for the adapter area of the code
dbt-adapters
Needs migration to the dbt-adapters repo
labels
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla:yes
dbt-adapters
Needs migration to the dbt-adapters repo
Team:Adapters
Issues designated for the adapter area of the code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-postgres#38
Problem
If someone is using the
Column.data_type
from aget_column_schema_from_query
call (like described in #8877), it might not be obvious when a translation fromtype_code
wasn't available.Solution
When a translation isn't possible, fire a debug-level logging event that is specific to this situation. Namely, a logging event like this:
Checklist
This PR includes type annotations for new and modified functions