-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cased comparison in catalog-retrieval function #8940
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8940 +/- ##
==========================================
- Coverage 86.50% 86.49% -0.01%
==========================================
Files 177 177
Lines 26405 26405
==========================================
- Hits 22841 22839 -2
- Misses 3564 3566 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Running |
These tests passed, it looks like this fixes the issue. |
* Fix cased comparison in catalog-retrieval function. * Fix cased comparison in catalog-retrieval function.
* Fix issues around new get_catalog_by_relations macro (#8856) * Fix issues around new get_catalog_by_relations macro * Add changelog entry * Fix unit test. * Additional unit testing * Fix cased comparison in catalog-retrieval function (#8940) * Fix cased comparison in catalog-retrieval function. * Fix cased comparison in catalog-retrieval function.
resolves #8939
Problem
Solution
Checklist