Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a no-op runner for saved_query #8937

Merged
merged 5 commits into from
Oct 31, 2023
Merged

add a no-op runner for saved_query #8937

merged 5 commits into from
Oct 31, 2023

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Oct 27, 2023 •
edited
Loading

resolves #8893

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner October 27, 2023 21:01
@cla-bot cla-bot bot added the cla:yes label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (35f46da) 86.36% compared to head (d313dca) 86.45%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8937      +/-   ##
==========================================
+ Coverage   86.36%   86.45%   +0.09%     
==========================================
  Files         177      177              
  Lines       26385    26439      +54     
==========================================
+ Hits        22787    22859      +72     
+ Misses       3598     3580      -18
Flag Coverage Δ
integration 83.27% <97.14%> (+0.05%) ⬆️
unit 64.79% <54.28%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/cli/main.py 98.43% <100.00%> (+<0.01%) ⬆️
core/dbt/cli/params.py 100.00% <100.00%> (ø)
core/dbt/compilation.py 96.21% <100.00%> (+0.37%) ⬆️
core/dbt/contracts/graph/nodes.py 94.21% <100.00%> (+0.01%) ⬆️
core/dbt/graph/selector.py 91.92% <100.00%> (+1.35%) ⬆️
core/dbt/graph/selector_methods.py 90.19% <ø> (ø)
core/dbt/task/runnable.py 92.08% <100.00%> (+0.04%) ⬆️
core/dbt/task/build.py 93.54% <95.83%> (+1.44%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aranke
aranke reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, couple nits and another test and should be good to go.

core/dbt/cli/params.py Show resolved Hide resolved
core/dbt/contracts/graph/nodes.py Show resolved Hide resolved
tests/functional/saved_queries/test_saved_query_build.py Outdated Show resolved Hide resolved
@ChenyuLInx ChenyuLInx requested a review from aranke October 31, 2023 18:04
peterallenwebb
peterallenwebb approved these changes Oct 31, 2023
View reviewed changes
core/dbt/task/build.py
from dbt.events.base_types import EventLevel


class SavedQueryRunner(BaseRunner):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this class go in its own file?

aranke
aranke approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenyuLInx ChenyuLInx mentioned this pull request Oct 31, 2023
Merged
5 tasks
@ChenyuLInx
Copy link
Contributor Author

I opted to not pull the runner out as changing it for all runners would be a very large change. @peterallenwebb

@ChenyuLInx ChenyuLInx merged commit 211392c into main Oct 31, 2023
50 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/8893 branch October 31, 2023 23:43
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@ChenyuLInx @github-actions
add a no-op runner for saved_query (#8937)
b6b452f 
(cherry picked from commit 211392c)
@graciegoheen graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Nov 1, 2023
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4383

ChenyuLInx added a commit that referenced this pull request Nov 1, 2023
@github-actions @ChenyuLInx
add a no-op runner for saved_query (#8937) (#8958)
333d793 
(cherry picked from commit 211392c)

Co-authored-by: Chenyu Li <[email protected]>
@dbeatty10 dbeatty10 mentioned this pull request Nov 1, 2023
Closed
@tlento tlento mentioned this pull request Nov 6, 2023
Merged
5 tasks
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 left review comments

@aranke aranke aranke approved these changes

@peterallenwebb peterallenwebb peterallenwebb approved these changes

@MichelleArk MichelleArk Awaiting requested review from MichelleArk

@QMalcolm QMalcolm Awaiting requested review from QMalcolm

Assignees
No one assigned
Labels
backport 1.7.latest cla:yes user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-3256] [implementation] conditionally include saved_queries in dbt build with no-op execution
6 participants
@ChenyuLInx @FishtownBuildBot @peterallenwebb @jtcohen6 @aranke @graciegoheen