-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/decouple adapters from core #8906
Merged
Merged
Changes from 44 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
469a9ac
remove dbt.contracts.connection imports from adapter module
MichelleArk c141148
Move events to common (#8676)
colin-rogers-dbt a89642a
fix import
MichelleArk dbd02e5
move types_pb2.py from events to common/events
MichelleArk f44d704
move agate_helper into common
MichelleArk 1a82548
Add utils module (#8910)
colin-rogers-dbt b9a603e
remove usage of dbt.config.PartialProject from dbt/adapters (#8909)
MichelleArk 200bcdc
Merge branch 'move-agate-client-to-common' into feature/decouple-adap…
MichelleArk 7de8930
move agate_helper unit tests under tests/unit/common
MichelleArk af91666
move agate_helper into common (#8911)
MichelleArk 333120b
Merge branch 'main' into feature/decouple-adapters-from-core
MichelleArk 1260782
remove dbt.flags.MP_CONTEXT usage in dbt/adapters (#8931)
MichelleArk c4ff280
remove dbt.flags.LOG_CACHE_EVENTS usage in dbt/adapters (#8933)
MichelleArk 4ee9504
Merge branch 'main' into feature/decouple-adapters-from-core
MichelleArk 51b94b2
Refactor Base Exceptions (#8989)
colin-rogers-dbt 1d0a3e9
Merge branch 'main' into feature/decouple-adapters-from-core
MichelleArk e56a5da
Remove usage of dbt.deprecations in dbt/adapters, enable core & adapt…
MichelleArk 2ab0f7b
Decouple adapter constraints from core (#9054)
peterallenwebb 615ad1f
move include/global_project to adapters (#8930)
MichelleArk 220f56d
remove adapter.get_compiler (#9134)
MichelleArk 8bad75c
Move adapter logger to adapters (#9165)
colin-rogers-dbt 12bd1e8
Merge branch 'main' into feature/decouple-adapters-from-core
MichelleArk 294ad82
delete accidentally merged types_pb2.py
MichelleArk 373125e
Move the semver package to common and alter references. (#9166)
VersusFacit 41ac915
Refactor EventManager setup and interaction (#9180)
colin-rogers-dbt 1bca662
first pass: adapter migration script (#9160)
MichelleArk 00f4920
Decouple macro generator from adapters (#9149)
MichelleArk e01eb30
Remove usage of dbt.contracts.relation in dbt/adapters (#9207)
MichelleArk ed8f5d3
Remove ResultNode usage from connections (#9211)
MichelleArk eb96e3d
Add RelationConfig Protocol for use in Relation.create_from (#9210)
MichelleArk 45b3570
Merge main into feature/decouple-adapters-from-core (#9240)
colin-rogers-dbt c2734c5
Merge branch 'main' into feature/decouple-adapters-from-core
MichelleArk f1c2f06
Move BaseConfig to Common (#9224)
colin-rogers-dbt 26ddaaf
Remove manifest from catalog and connection method signatures (#9242)
MichelleArk 4d16524
Add MacroResolverProtocol, remove lazy loading of manifest in adapter…
MichelleArk c7b9b1a
pass context to MacroQueryStringSetter (#9248)
MichelleArk a68e427
add macro_context_generator on adapter (#9251)
MichelleArk 61db33a
Pass mp_context to adapter factory (#9275)
colin-rogers-dbt 0b5a4d3
Fix include for decoupling (#9286)
colin-rogers-dbt 4bb1d4b
Fix include for decoupling (#9288)
colin-rogers-dbt 308a7e9
move system client to common (#9294)
colin-rogers-dbt 7e5a87a
Update materialized views to use RelationConfigs and remove refs to d…
colin-rogers-dbt c08af13
Add config field to RelationConfig (#9300)
colin-rogers-dbt 34f77d9
merge main into feature/decouple-adapters-from-core (#9305)
colin-rogers-dbt ff52aef
resolve merge conflict on unparsed.py (#9309)
colin-rogers-dbt ab0e4c4
Resolve unparsed.py conflict (#9311)
colin-rogers-dbt ac3b17f
Merge branch 'main' into feature/decouple-adapters-from-core
ChenyuLInx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Breaking Changes | ||
body: Remove adapter.get_compiler interface | ||
time: 2023-11-27T11:47:57.443202-05:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9148" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Breaking Changes | ||
body: Move AdapterLogger to adapters folder | ||
time: 2023-11-28T13:43:56.853925-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9151" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Breaking Changes | ||
body: Rm --dry-run flag from 'dbt deps --add-package', in favor of just 'dbt deps | ||
--lock' | ||
time: 2023-11-29T09:19:21.071212+01:00 | ||
custom: | ||
Author: jtcohen6 | ||
Issue: "9100" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Breaking Changes | ||
body: move event manager setup back to core, remove ref to global EVENT_MANAGER and | ||
clean up event manager functions | ||
time: 2023-11-30T13:53:48.645192-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9150" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: 'Allow adapters to include package logs in dbt standard logging ' | ||
time: 2023-09-15T12:37:33.862862-07:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "7859" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: migrate utils to common and adapters folders | ||
time: 2023-10-26T11:08:21.458709-07:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "8924" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Move Agate helper client into common | ||
time: 2023-10-26T12:35:56.538587-07:00 | ||
custom: | ||
Author: MichelleArk | ||
Issue: "8926" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: remove usage of dbt.config.PartialProject from dbt/adapters | ||
time: 2023-10-26T12:39:13.904116-07:00 | ||
custom: | ||
Author: MichelleArk | ||
Issue: "8928" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Remove legacy logger | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we don't use this on cloud anymore, do we need to double check? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MichelleArk checked and they have all moved to event logging |
||
time: 2023-11-07T13:56:35.186648-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "8027" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Features | ||
body: Adds support for parsing conversion metric related properties for the semantic | ||
layer. | ||
time: 2023-12-06T18:14:58.688221-05:00 | ||
custom: | ||
Author: WilliamDee | ||
Issue: "9203" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Added more type annotations. | ||
time: 2023-08-31T16:44:35.737954-04:00 | ||
custom: | ||
Author: peterallenwebb | ||
Issue: "8537" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Remove usage of dbt.include.global_project in dbt/adapters | ||
time: 2023-10-26T18:49:53.36449-04:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "8925" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: remove dbt.flags.MP_CONTEXT usage in dbt/adapters | ||
time: 2023-11-01T10:27:58.790153-04:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "8967" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: 'Remove usage of dbt.flags.LOG_CACHE_EVENTS in dbt/adapters' | ||
time: 2023-11-01T17:31:24.974093-04:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "8969" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Remove use of dbt/core exceptions in dbt/adapter | ||
time: 2023-11-07T13:57:28.683727-08:00 | ||
custom: | ||
Author: colin-rogers-dbt MichelleArk | ||
Issue: "8920" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Under the Hood | ||
body: Remove usage of dbt.deprecations in dbt/adapters, enable core & adapter-specific | ||
event types and protos | ||
time: 2023-11-16T17:42:51.005023-05:00 | ||
custom: | ||
Author: michelleark | ||
Issue: 8927 8918 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Under the Hood | ||
body: Move column constraints into common/contracts, removing another dependency of | ||
adapters on core. | ||
time: 2023-11-20T18:32:14.859503-05:00 | ||
custom: | ||
Author: peterallenwebb | ||
Issue: "9024" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Move dbt.semver to dbt.common.semver and update references. | ||
time: 2023-11-28T17:07:32.172421-08:00 | ||
custom: | ||
Author: versusfacit | ||
Issue: "9039" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Move lowercase utils method to common | ||
time: 2023-11-30T13:54:32.561673-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9180" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Remove usages of dbt.clients.jinja in dbt/adapters | ||
time: 2023-12-05T09:35:44.845352+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9205" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Remove usage of dbt.contracts in dbt/adapters | ||
time: 2023-12-05T12:05:59.936775+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9208" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Remove usage of dbt.contracts.graph.nodes.ResultNode in dbt/adapters | ||
time: 2023-12-05T16:58:12.932172+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9214" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Introduce RelationConfig Protocol, consolidate Relation.create_from | ||
time: 2023-12-05T17:07:25.33861+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9215" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
kind: Under the Hood | ||
body: Move BaseConfig, Metadata and various other contract classes from model_config | ||
to common/contracts/config | ||
time: 2023-12-05T18:50:22.321229-08:00 | ||
custom: | ||
Author: colin-rorgers-dbt | ||
Issue: "8919" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: remove manifest from adapter.set_relations_cache signature | ||
time: 2023-12-05T23:58:30.920144+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9217" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: ' remove manifest from adapter catalog method signatures' | ||
time: 2023-12-06T00:03:43.824252+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9218" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: Add MacroResolverProtocol, remove lazy loading of manifest in adapter.execute_macro | ||
time: 2023-12-07T11:15:54.427818+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9244" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: pass query header context to MacroQueryStringSetter | ||
time: 2023-12-07T22:41:39.498024+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: 9249 9250 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: add macro_context_generator on adapter | ||
time: 2023-12-08T00:48:54.506911+09:00 | ||
custom: | ||
Author: michelleark | ||
Issue: "9247" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: pass mp_context to adapter factory as argument instead of import | ||
time: 2023-12-12T15:48:42.866175-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9025" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: have dbt-postgres use RelationConfig protocol for materialized views' | ||
time: 2023-12-14T12:21:34.756973-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9292" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Under the Hood | ||
body: move system.py to common as dbt-bigquery relies on it to call gcloud | ||
time: 2023-12-14T16:41:07.539814-08:00 | ||
custom: | ||
Author: colin-rogers-dbt | ||
Issue: "9293" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,5 @@ ignore = | |
E741 | ||
E501 # long line checking is done in black | ||
exclude = test/ | ||
per-file-ignores = | ||
*/__init__.py: F401 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
recursive-include dbt/include *.py *.sql *.yml *.html *.md .gitkeep .gitignore | ||
recursive-include dbt/adapters/include *.py *.sql *.yml *.html *.md .gitkeep .gitignore | ||
include dbt/py.typed | ||
recursive-include dbt/task/docs *.html |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems not so relevant to what you are doing in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I'm not sure why this shows as a diff as the PR for this was merged last week?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9169