ADAP-835: Optimize manual refresh on auto-refreshed materialized views #8847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bt with no changes
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8847 +/- ##
==========================================
- Coverage 86.35% 86.30% -0.06%
==========================================
Files 177 179 +2
Lines 26383 26453 +70
==========================================
+ Hits 22784 22829 +45
- Misses 3599 3624 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…esh before manually refreshing in the materialization
… into the base relation config
mikealfare
commented
Oct 14, 2023
| @@ -66,31 +65,16 @@ def from_dict(cls, config_dict: dict) -> "PostgresMaterializedViewConfig": | |||
| return materialized_view | |||
|
|
|||
| @classmethod | |||
| def from_model_node(cls, model_node: ModelNode) -> "PostgresMaterializedViewConfig": | |||
There was a problem hiding this comment.
Moved to RelationConfigBase
mikealfare
commented
Oct 14, 2023
| } | ||
| return config_dict | ||
|
|
||
| @classmethod | ||
| def from_relation_results( |
There was a problem hiding this comment.
Moved to RelationConfigBase
mikealfare
commented
Oct 14, 2023
| @@ -36,7 +37,6 @@ class PostgresMaterializedViewConfig(RelationConfigBase, RelationConfigValidatio | |||
| """ | |||
|
|
|||
| table_name: str = "" | |||
| query: str = "" | |||
There was a problem hiding this comment.
This was not used, and is the only difference in this context between a ModelNode and a ParsedNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6911
Problem
dbt runwill issue a manual refresh of a materialized view if there are no changes detected during a run. This happens regardless of whether the materialized view is setup to be automatically refreshed. If the materialized view is already scheduled to be refreshed, there is no need to insert an additional refresh. This will add cost and potentially introduce unexpected data as the refresh schedule will not match what's set with the extra refresh.Solution
dbt will inspect the materialized view to determine if it is set to automatically refresh. If it is, and there are no changes, then
dbt runwill do nothing. If it is not set to automatically refresh, thendbt runwill issue a refresh command.Checklist