Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capability.py #8842

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update capability.py #8842

merged 1 commit into from
Nov 6, 2023

Conversation

dataders
Copy link
Contributor

resolves #8841

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@dataders dataders requested a review from a team as a code owner October 12, 2023 15:29
@dataders dataders requested a review from Fleid October 12, 2023 15:29
@cla-bot cla-bot bot added the cla:yes label Oct 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1baebb4) 86.30% compared to head (26a0ec6) 86.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8842   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         177      177           
  Lines       26383    26383           
=======================================
  Hits        22771    22771           
  Misses       3612     3612           
Flag Coverage Δ
integration 83.09% <ø> (ø)
unit 64.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/adapters/capability.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dataders dataders added the Skip Changelog Skips GHA to check for changelog file label Oct 12, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 6, 2023

@dataders LGTM, it's just a docstring update, and @peterallenwebb has already approved, so I'm going to press the "merge" button

@jtcohen6 jtcohen6 merged commit c7c3ac8 into main Nov 6, 2023
58 of 60 checks passed
@jtcohen6 jtcohen6 deleted the fix-capability-docstring branch November 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3213] [Bug] nitpick: incorrect docstring
3 participants