Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v10 manifest on main #8834

Merged
merged 2 commits into from
Oct 11, 2023
Merged

update v10 manifest on main #8834

merged 2 commits into from
Oct 11, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 11, 2023

resolves #8835

Problem

The v10 manifest for 1.6 has been updated to add fields but those changes are not reflected on main.

Solution

Cath up the v10 manifest schema.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 11, 2023
@emmyoop emmyoop changed the title update manifest update v10 manifest Oct 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a377749) 86.44% compared to head (d3fa31c) 86.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8834   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files         176      176           
  Lines       26043    26043           
=======================================
  Hits        22512    22512           
  Misses       3531     3531           
Flag Coverage Δ
integration 83.24% <ø> (ø)
unit 64.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review October 11, 2023 18:19
@emmyoop emmyoop requested review from a team as code owners October 11, 2023 18:19
@emmyoop emmyoop requested review from jzhu13 and peterallenwebb and removed request for a team October 11, 2023 18:19
@emmyoop emmyoop changed the title update v10 manifest update v10 manifest on main Oct 11, 2023
@emmyoop emmyoop merged commit bf10a29 into main Oct 11, 2023
48 checks passed
@emmyoop emmyoop deleted the er/catch-up-v10-manifest branch October 11, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3209] Catch the v10 manifest schema up on main
2 participants