DO NOT MERGE / TEST: only for diff #8830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test * write test * fix test * updating test * add clean * cleanup * more tests, fix comment * add new test, move fixtures
* add `store_failures_as` parameter to TestConfig, catch strategy parameter in test materialization * create test results as views * updated test expected values for new config option * break up tests into reusable tests and adapter specific configuration, update test to check for relation type and confirm views update * move test configuration into base test class * allow `store_failures_as` to drive whether failures are stored * update expected test config dicts to include the new default value for store_failures_as * Add `store_failures_as` config for generic tests * cover --store-failures on CLI gap * add generic tests test case for store_failures_as * update object names for generic test case tests for store_failures_as * remove unique generic test, it was not testing `store_failures_as` * pull generic run and assertion into base test class to turn tests into quasi-parameterized tests * add ephemeral option for store_failures_as, as a way to easily turn off store_failures at the model level * add compilation error for invalid setting of store_failures_as --------- Co-authored-by: Doug Beatty <[email protected]>
* Bump docker/build-push-action from 4 to 5 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Add automated changelog yaml from template for bot PR --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <[email protected]>
* update manifest * add changelog
* Add support for getting freshness from DBMS metadata * Add changelog entry * Add simple test case * Change parsing error to warning and add new event type for warning * Code review simplification of capability dict. * Revisions to the capability mechanism per review * Move utility function. * Reduce try/except scope * Clean up imports. * Simplify typing per review * Unit test fix
* Bump to dbt-semantic-interfaces 0.3.0b1 * Update import path of `WhereFilterParser` from `dbt-semantic-interfaces` In 0.3.x of `dbt-semantic-intefaces` the location of the WhereFilterParser moved to be grouped in with a bunch of new adjacent code. As such, we needed to correct our import path of it. * Create basic `SavedQuery` node type based on `SavedQuery` protocol from DSI * Add ability to add SavedQueries to the manifest * Define unparsed SavedQuery node * Begin parsing saved_query objects to manifest * Skip jinja rendering of `SavedQuery.where` property * Begin propagating `SavedQueries` on the manifest to the semantic manifest * Add tests for basic saved query parsing * Add custom pluralization handling of SavedQuery node type * Add a config subclass to SavedQuery node * Move the SavedQuery node to nodes.py Unfortunately things are a bit too intertwined currently for SavedQuery to be in it's own file. We need to add the SavedQuery node to the GraphMemberNode, unfortunately with SavedQuery in it's own file, importing it would have caused a circular dependency. We'll need to separately come in and split things up as a cleanup portion of work. * Add basic plumbing of saved query configs to projects * Add basic lookup utility for saved queries, SavedQueryLookup * Handle disabled SavedQuery nodes in parsing and lookups * Add SavedQuery nodes to grouping process Our grouping logic seems to be in a weird spot. It seems liek we're moving to setting the `group` for a node in the node's `config` however, all of the logic around grouping is still focused on the top level `group` property on a nodes. To get group stuff plumbed I've thus added `group` as a top level property of the `SavedQuery` node, and populated it from the config group value. * Plumb through saved query in a lot more places I don't like making scatter shot commits like this. However, a lot of this commit was written ~4am, soooo yea. Things were broken, I wanted things to be unbroken. I mostly searched for `semantic_models` and added the equivalent necessary `saved_queries`. Some stuff is in support of writing out the manifest, some stuff helps with node selection, it's a lot of miscelaneous stuff that I don't fully understand. * Add `depends_on` to `SavedQuery` nodes and populate from `metrics` property * Add partial parsing support to SavedQuery nodes * Add `docs` support for SavedQuery descriptions * Support selctor methods for SavedQuery nodes * Add `refs` property to SavedQuery node We don't actually append anything to `refs` for SavedQuery nodes currently. I'm not sure if anything needs to be appended to them. Regardless, we access the `refs` property throughout the codebase while iterating over nodes. It seems wise to support this attribute as to not accidently blow something up with it not existing. * Support `saved_queries` when upgrading from manifests <= v10 (and regenerate v11) * Add changie doc for saved query node support * Pin to dbt-semantic-interfaces 0.3.0b1 for saved query work We're gonna release DSI 0.3.0, and if this PR automatically pulls that in things will break. But the things that need fixing should be handled separately from this PR. After releasing DSI 0.3.0 I'm going to create a branch off/ontop of this one, and open a stacked PR with the associated changes. * Bump supported DSI version to 0.3.x * Switch metric filters and saved query where to use ne WhereFilterIntersection * Update schema yaml readers to create WhereFilterInterfaces * Expand metric filters and saved query where property to handle both str and list of strs * Update tests which were broken by where filter changes * Regeneate v11 manifest * Fixup: Update `SavedQueryLookup.perform_lookup` to operate on saved queries I missed this when I was copy and pasting 🤦
* changie doc for DSI 0.3.0 upgrade * Gracefully handle v10 metric filters * Fix iteration over metrics in `upgrade_v10_metric_filters` * Update previous manifest version test fixtures to have more expressive metrics * Regenerate the test v10 manifest artifact using the more expressive metrics from 904cc1e To do this I cherry-picked 904cc1e onto my local 1.6.latest branch, had the test regenerate the test v10 manifest artifact, and then over wrote the test v10 manifest artifact on this branch (cherry-picking it across the branches didn't work, had to copy paste :grimmace:) * Regenerate test v11 manifest artifact using the fixture changes in 904cc1e * Update `upgrade_v10_metric_filters` to handled disabled metrics Regenerating the v10 and v11 test manifest artifacts uncovered an issue wherein we weren't handling disabled metrics that need to get upgraded. This commit fixes that. Additionally, the `upgrade_v10_metric_filters` was getting a bit unwieldy, so I broke extracted the abstracted sub functions. * Fix `test_backwards_compatible_versions` test When we regenerated the v10 test manifest artifact, it started having the `metricflow_time_sine` model, and it didn't previously. This caused `test_backwards_compatible_versions` to start failing because it was no longer identified as having modified state for v10. The test has been altered accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just doing to review changes to write the upgrade guide