-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectors in docs generate limits catalog generation #8772
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8772 +/- ##
==========================================
- Coverage 86.50% 86.50% -0.01%
==========================================
Files 176 176
Lines 25821 25841 +20
==========================================
+ Hits 22337 22354 +17
- Misses 3484 3487 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4203 |
resolves #6014
Problem
Catalog generation is expensive, so we want to limit catalog queries to only the selected nodes.
Solution
Retrieve the selected node unique_ids and pass them to the methods used to get the catalog information.
Docs
In the past using a selector on docs generate would only affect which nodes were compiled. With this change, selectors will limit the information in the catalog.json.
Checklist