Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.6.latest] regenerate v10 manifest #8765

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[1.6.latest] regenerate v10 manifest #8765

merged 2 commits into from
Oct 4, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 4, 2023

resolves #8763

Problem

Support for labels in semantic models was backported to 1.6 but the manifest was not regenerated to support it so the v10 manifest schema cannot be used to validate manifests.

Solution

Update the v10 manifest json schema.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested review from a team as code owners October 4, 2023 12:59
@emmyoop emmyoop requested review from ashnm and peterallenwebb and removed request for a team October 4, 2023 12:59
@cla-bot cla-bot bot added the cla:yes label Oct 4, 2023
@emmyoop emmyoop changed the title regenerate v10 manifest [1.6.latest] regenerate v10 manifest Oct 4, 2023
@emmyoop emmyoop merged commit 6946a20 into 1.6.latest Oct 4, 2023
52 checks passed
@emmyoop emmyoop deleted the er/8763-1.6-manifest branch October 4, 2023 19:52
@emmyoop emmyoop mentioned this pull request Oct 4, 2023
Closed
2 tasks
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martynydbt martynydbt martynydbt approved these changes

@graciegoheen graciegoheen graciegoheen approved these changes

@ashnm ashnm Awaiting requested review from ashnm ashnm is a code owner automatically assigned from dbt-labs/cloud-artifacts

@peterallenwebb peterallenwebb Awaiting requested review from peterallenwebb peterallenwebb is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmyoop @graciegoheen @martynydbt