Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8160: Warn when --state == --target #8638

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Fix #8160: Warn when --state == --target #8638

merged 6 commits into from
Sep 14, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 12, 2023

resolves #8160

A/C from ticket:

  • Raise a warning whenever --state path == --target-path
  • Update logic of create_or_replace_clone as described

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@aranke aranke requested review from a team as code owners September 12, 2023 21:53
@cla-bot cla-bot bot added the cla:yes label Sep 12, 2023
@aranke aranke requested review from gshank, jtcohen6 and McKnight-42 and removed request for colin-rogers-dbt and martynydbt September 12, 2023 21:54
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (3cc7044) 86.56% compared to head (630927c) 86.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8638      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.01%     
==========================================
  Files         175      175              
  Lines       25596    25610      +14     
==========================================
+ Hits        22157    22168      +11     
- Misses       3439     3442       +3     
Flag Coverage Δ
integration 83.35% <100.00%> (-0.01%) ⬇️
unit 65.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/events/types_pb2.py 1.44% <ø> (+0.10%) ⬆️
core/dbt/contracts/state.py 80.85% <100.00%> (+1.78%) ⬆️
core/dbt/events/types.py 98.64% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke requested a review from MichelleArk September 14, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2850] [Feature] Raise a warning when --state path == --target-path
3 participants