Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace is_replaceable function with can_be_replaced call #8637

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (5182e3c) 86.61% compared to head (769bc5f) 86.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8637      +/-   ##
==========================================
- Coverage   86.61%   86.56%   -0.05%     
==========================================
  Files         175      175              
  Lines       25595    25595              
==========================================
- Hits        22168    22156      -12     
- Misses       3427     3439      +12     
Flag Coverage Δ
integration 83.35% <ø> (-0.11%) ⬇️
unit 65.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@McKnight-42 McKnight-42 self-requested a review September 13, 2023 06:18
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Sep 13, 2023
@mikealfare mikealfare marked this pull request as ready for review September 13, 2023 14:18
@mikealfare mikealfare requested a review from a team as a code owner September 13, 2023 14:18
@mikealfare mikealfare merged commit 8aaed0e into main Sep 13, 2023
58 of 60 checks passed
@mikealfare mikealfare deleted the fixReplaceSQLReplaced branch September 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants