Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Tests: split up dbt show test class #8610

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Flaky Tests: split up dbt show test class #8610

merged 1 commit into from
Sep 12, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 11, 2023

resolves #8470
docs dbt-labs/docs.getdbt.com/#

Problem

TestShow::test_numeric_values & TestShow::test_numeric_values_with_nulls are flaky

Solution

Split up tests into separate classes

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Sep 11, 2023
@emmyoop emmyoop requested a review from a team as a code owner September 11, 2023 13:53
@emmyoop emmyoop requested a review from MichelleArk September 11, 2023 13:53
@cla-bot cla-bot bot added the cla:yes label Sep 11, 2023
@emmyoop emmyoop changed the title split up test class split up dbt show test class Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (b39eeb3) 86.61% compared to head (fc6ed96) 86.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8610      +/-   ##
==========================================
- Coverage   86.61%   86.56%   -0.05%     
==========================================
  Files         174      174              
  Lines       25590    25590              
==========================================
- Hits        22164    22152      -12     
- Misses       3426     3438      +12     
Flag Coverage Δ
integration 83.36% <ø> (-0.13%) ⬇️
unit 65.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop changed the title split up dbt show test class Flaky Tests: split up dbt show test class Sep 11, 2023
@emmyoop emmyoop merged commit 5182e3c into main Sep 12, 2023
64 of 65 checks passed
@emmyoop emmyoop deleted the er/8470-test-show branch September 12, 2023 15:59
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
(cherry picked from commit 5182e3c)
emmyoop added a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit 5182e3c)

Co-authored-by: Emily Rockman <[email protected]>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3019] TestShow::test_numeric_values, TestShow::test_numeric_values_with_nulls are flaky
2 participants