Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column quotes in macro to avoid build failure #8529

Closed
wants to merge 5 commits into from
Closed

Add column quotes in macro to avoid build failure #8529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67dbf4e
Add column quotes to avoid build failure
seanglynn-thrive Aug 31, 2023
d784d09
Changelog entry
dbeatty10 Sep 18, 2023
4be9301
Merge branch 'dbt-labs:main' into add-column-name-quotes
seanglynn-thrive Sep 19, 2023
bad7728
Update issue ref
seanglynn-thrive Sep 19, 2023
a1d17ab
Update .changes/unreleased/Fixes-20230918-145127.yaml
seanglynn-thrive Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230918-145127.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Add column quotes in macro to avoid build failure
time: 2023-09-18T14:51:27.988997-06:00
custom:
Author: seanglynn-thrive
Issue: "8667"
4 changes: 2 additions & 2 deletions core/dbt/include/global_project/macros/adapters/columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@
alter {{ relation.type }} {{ relation }}

{% for column in add_columns %}
add column {{ column.name }} {{ column.data_type }}{{ ',' if not loop.last }}
add column {{ adapter.quote(column.name) }} {{ column.data_type }}{{ ',' if not loop.last }}
{% endfor %}{{ ',' if add_columns and remove_columns }}

{% for column in remove_columns %}
drop column {{ column.name }}{{ ',' if not loop.last }}
drop column {{ adapter.quote(column.name) }}{{ ',' if not loop.last }}
{% endfor %}

{%- endset -%}
Expand Down