Test case for merge_exclude_columns
#8268
Merged
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8267
Problem
The source code here doesn't include TestMergeExcludeColumns like dbt-snowflake does here or dbt-redshift does here.
This is because merge wasn't a supported incremental strategy for dbt-postgres until 1.6 and adding relevant functional tests was overlooked during implementation in #6951.
The other related test cases have a class that pytest will pick up:
dbt-core/tests/functional/adapter/incremental/test_incremental_unique_id.py
Line 566 in db69473
dbt-core/tests/functional/adapter/incremental/test_incremental_predicates.py
Line 144 in db69473
dbt-core/tests/functional/adapter/incremental/test_incremental_on_schema_change.py
Line 99 in db69473
Solution
Implement a test case that pytest will pick up (namely a class that begins with "Test").
Prerequisites
In order for this PR to work, it needs this:
Checklist