fix: partial parsing - reparse downstream nodes when adding versioning #11184
+79
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # #8872
Problem
Adding versioning to a model with dependencies requires a full-parse. See workaround.
Solution
Schedule referencing nodes for parsing if the model in the new schema file is versioned (here).
Reviewer Questions
delete_schema_mssa_links
but I ignored hints on the assignments to avoid including a larger refactor in this PR. Is there a preference for how type changes like this are handled? I see a mix of blanket ignores and type specific ignores (e.g.# type: ignore[assignment]
).Checklist