Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check modified contracts when doing state:modified #11161

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Dec 17, 2024

Resolves #11034

Problem

Checking modified:contract needed to be run separately, which users found unexpected.

Solution

Call check_modified_contract when running check_modified.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner December 17, 2024 20:51
@cla-bot cla-bot bot added the cla:yes label Dec 17, 2024
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (a175793) to head (8e01605).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11161   +/-   ##
=======================================
  Coverage   88.88%   88.89%           
=======================================
  Files         187      187           
  Lines       24001    24007    +6     
=======================================
+ Hits        21334    21340    +6     
  Misses       2667     2667           
Flag Coverage Δ
integration 86.20% <100.00%> (+<0.01%) ⬆️
unit 62.03% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.03% <100.00%> (+0.04%) ⬆️
Integration Tests 86.20% <100.00%> (+<0.01%) ⬆️

@gshank gshank merged commit 88e953e into main Dec 18, 2024
56 checks passed
@gshank gshank deleted the state_modified_contract branch December 18, 2024 20:40
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
gshank added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] state:modified should include check_modified_contract
2 participants