Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partial parsing for singular data tests configs in yaml files #11100

Merged
merged 5 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241205-145307.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Implement partial parsing for singular data test configs in yaml files
time: 2024-12-05T14:53:07.295536-05:00
custom:
Author: gshank
Issue: "10801"
18 changes: 18 additions & 0 deletions core/dbt/parser/partial.py
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,7 @@
handle_change("semantic_models", self.delete_schema_semantic_model)
handle_change("unit_tests", self.delete_schema_unit_test)
handle_change("saved_queries", self.delete_schema_saved_query)
handle_change("data_tests", self.delete_schema_data_test_patch)

def _handle_element_change(
self, schema_file, saved_yaml_dict, new_yaml_dict, env_var_changes, dict_key: str, delete
Expand Down Expand Up @@ -919,6 +920,23 @@
self.saved_files[macro_file_id] = deepcopy(self.new_files[macro_file_id])
self.add_to_pp_files(self.saved_files[macro_file_id])

def delete_schema_data_test_patch(self, schema_file, data_test):
data_test_unique_id = None
for unique_id in schema_file.node_patches:
if not unique_id.startswith("test"):
continue

Check warning on line 927 in core/dbt/parser/partial.py

View check run for this annotation

Codecov / codecov/patch

core/dbt/parser/partial.py#L927

Added line #L927 was not covered by tests
parts = unique_id.split(".")
elem_name = parts[2]
if elem_name == data_test["name"]:
data_test_unique_id = unique_id
break
if data_test_unique_id and data_test_unique_id in self.saved_manifest.nodes:
singular_data_test = self.saved_manifest.nodes.pop(data_test_unique_id)
file_id = singular_data_test.file_id
if file_id in self.new_files:
self.saved_files[file_id] = deepcopy(self.new_files[file_id])
self.add_to_pp_files(self.saved_files[file_id])

# exposures are created only from schema files, so just delete
# the exposure or the disabled exposure.
def delete_schema_exposure(self, schema_file, exposure_dict):
Expand Down
2 changes: 0 additions & 2 deletions core/dbt/parser/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -1199,8 +1199,6 @@ def parse_patch(self, block: TargetBlock[UnparsedSingularTestUpdate], refs: Pars
node.patch_path = patch.file_id
node.description = patch.description
node.created_at = time.time()
node.meta = patch.meta
node.docs = patch.docs


class MacroPatchParser(PatchParser[UnparsedMacroUpdate, ParsedMacroPatch]):
Expand Down
14 changes: 12 additions & 2 deletions tests/functional/data_test_patch/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,18 @@
description: "{{ doc('my_singular_test_documentation') }}"
config:
error_if: ">10"
meta:
some_key: some_val
meta:
some_key: some_val
"""

tests__schema_2_yml = """
data_tests:
- name: my_singular_test
description: "My singular test description"
config:
error_if: ">10"
meta:
some_key: another_val
"""

tests__doc_block_md = """
Expand Down
24 changes: 17 additions & 7 deletions tests/functional/data_test_patch/test_singular_test_patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

import pytest

from dbt.tests.util import get_artifact, run_dbt, run_dbt_and_capture
from dbt.tests.util import get_manifest, run_dbt, run_dbt_and_capture, write_file
from tests.functional.data_test_patch.fixtures import (
tests__doc_block_md,
tests__invalid_name_schema_yml,
tests__malformed_schema_yml,
tests__my_singular_test_sql,
tests__schema_2_yml,
tests__schema_yml,
)

Expand All @@ -23,13 +24,22 @@ def tests(self):

def test_compile(self, project):
run_dbt(["compile"])
manifest = get_artifact(project.project_root, "target", "manifest.json")
assert len(manifest["nodes"]) == 1
manifest = get_manifest(project.project_root)
assert len(manifest.nodes) == 1

my_singular_test_node = manifest["nodes"]["test.test.my_singular_test"]
assert my_singular_test_node["description"] == "Some docs from a doc block"
assert my_singular_test_node["config"]["error_if"] == ">10"
assert my_singular_test_node["config"]["meta"] == {"some_key": "some_val"}
my_singular_test_node = manifest.nodes["test.test.my_singular_test"]
assert my_singular_test_node.description == "Some docs from a doc block"
assert my_singular_test_node.config.error_if == ">10"
assert my_singular_test_node.config.meta == {"some_key": "some_val"}
assert my_singular_test_node.meta == {"some_key": "some_val"}

# partial parsing test
write_file(tests__schema_2_yml, project.project_root, "tests", "schema.yml")
manifest = run_dbt(["parse"])
test_node = manifest.nodes["test.test.my_singular_test"]
assert test_node.description == "My singular test description"
assert test_node.config.meta == {"some_key": "another_val"}
assert test_node.meta == {"some_key": "another_val"}


class TestPatchSingularTestInvalidName:
Expand Down
Loading