-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11012: Catch DbtRuntimeError for hooks #11023
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11023 +/- ##
==========================================
- Coverage 89.15% 89.13% -0.03%
==========================================
Files 183 183
Lines 23764 23764
==========================================
- Hits 21186 21181 -5
- Misses 2578 2583 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that it ended up being pretty simple!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-11023-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f582ac2488c9175ec0d3297336099cf5593acf17
# Push it to GitHub
git push --set-upstream origin backport-11023-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
(cherry picked from commit f582ac2) Co-authored-by: Kshitij Aranke <[email protected]> Co-authored-by: Gerda Shank <[email protected]>
Resolves #11012
Problem
DbtRuntimeError
was not caught for hooks, which resulted inrun_results.json
not being written.Solution
Explicitly catch
DbtRuntimeError
Checklist