Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] add index.html to .gitignore #11008

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[QOL] add index.html to .gitignore #11008

merged 1 commit into from
Nov 15, 2024

Conversation

MichelleArk
Copy link
Contributor

Resolves #N/A

Running unit tests currently leaves an index.html artifact that you need to be mindful of checking in. Let's .gitignore it!

@MichelleArk MichelleArk added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Nov 15, 2024
@MichelleArk MichelleArk requested a review from a team as a code owner November 15, 2024 21:22
@cla-bot cla-bot bot added the cla:yes label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (84230ce) to head (b12142f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11008   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files         183      183           
  Lines       23638    23638           
=======================================
  Hits        21057    21057           
  Misses       2581     2581           
Flag Coverage Δ
integration 86.40% <ø> (ø)
unit 62.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.77% <ø> (ø)
Integration Tests 86.40% <ø> (ø)

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MichelleArk MichelleArk merged commit 945539e into main Nov 15, 2024
73 checks passed
@MichelleArk MichelleArk deleted the gitignore-index-html branch November 15, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants