Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dbt adapters minior minimum to 1.8.0 #10947

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

QMalcolm
Copy link
Contributor

Resolves N/A

Problem

In #10859 we started using the get_adapter_run_info method provided by dbt-adapters. However, that function is only available in dbt-adapters >= 1.8.0. Thus, 1.8.0 is our new minimum for dbt-adapters.

Solution

Raise the minimum allowed dbt-adapters version to 1.8.0.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

In #10859 we started using the
`get_adapter_run_info` method provided by `dbt-adapters`. However that
function is only available in dbt-adapters >= 1.8.0. Thus 1.8.0 is our
new minimum for dbt-adapters.
@QMalcolm QMalcolm requested a review from a team as a code owner October 30, 2024 18:47
@cla-bot cla-bot bot added the cla:yes label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (dd77210) to head (035386d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10947      +/-   ##
==========================================
- Coverage   89.19%   86.45%   -2.75%     
==========================================
  Files         183      183              
  Lines       23496    23496              
==========================================
- Hits        20958    20314     -644     
- Misses       2538     3182     +644     
Flag Coverage Δ
integration 86.45% <ø> (-0.13%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.45% <ø> (-2.75%) ⬇️
Integration Tests 86.45% <ø> (-0.13%) ⬇️

@QMalcolm QMalcolm merged commit 8de0229 into main Oct 30, 2024
65 of 67 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--bump-dbt-adapters-minimum-minor branch October 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants