Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test source and model quoting respects dbt_project configs as documented #10906

Closed
wants to merge 3 commits into from

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Oct 22, 2024

Resolves #

Problem

No tests for previously documented behaviour: (here and here). The quoting: config in the dbt_project.yml file is just for creating relations / resolving a ref, and this is truly addressing

Solution

Add tests! Mirroring those brought in for a regression fix in #10905

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (d75689f) to head (991b265).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest   #10906      +/-   ##
==============================================
- Coverage       86.73%   86.66%   -0.07%     
==============================================
  Files             179      179              
  Lines           26728    26728              
==============================================
- Hits            23182    23165      -17     
- Misses           3546     3563      +17     
Flag Coverage Δ
integration 83.48% <ø> (-0.17%) ⬇️
unit 65.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk changed the title TestSourceQuotingLegacy Test source and model quoting respects dbt_project configs correctly Oct 24, 2024
@MichelleArk MichelleArk changed the title Test source and model quoting respects dbt_project configs correctly Test source and model quoting respects dbt_project configs as documented Oct 24, 2024
@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant