Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update microbatch tests to handle update wherein incremental strategies are always validated #10884

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Update microbatch tests to handle update wherein incremental strategies are always validated #10884

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c00c9c0
Update microbatch tests to handle update wherein incremental strategi…
QMalcolm Oct 18, 2024
46b59f0
Merge branch 'main' into qmalcolm--fix-microbatch-test
QMalcolm Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/functional/microbatch/test_microbatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,8 @@ def test_use_custom_microbatch_strategy_env_var_true_invalid_incremental_strateg
with mock.patch.object(
type(project.adapter), "valid_incremental_strategies", lambda _: []
):
# Initial run
with patch_microbatch_end_time("2020-01-03 13:57:00"):
run_dbt(["run"])

# Incremental run fails
# Run of microbatch model while adapter doesn't have a "valid"
# microbatch strategy causes an error to be raised
with patch_microbatch_end_time("2020-01-03 13:57:00"):
_, logs = run_dbt_and_capture(["run"], expect_pass=False)
assert "'microbatch' is not valid" in logs
Expand Down
Loading