-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.8 from various places #10861
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10861 +/- ##
==========================================
- Coverage 89.19% 89.13% -0.07%
==========================================
Files 183 183
Lines 23434 23434
==========================================
- Hits 20903 20888 -15
- Misses 2531 2546 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I don't see why "unit test / python 3.8" was trying to run. |
Ran the Tests and Code Checks pipeline successfully with these changes: https://github.com/dbt-labs/dbt-core/actions/runs/11371519059 |
It won't let us merge with that failing "unit test / python 3.8". Also I'm wondering if there's anything that needs to be done about codecov? |
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]>
* Remove Python 3.8 from various places (#10861) * Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <[email protected]> * Revise test to reflect change in dbt-common * Add another unit test. --------- Co-authored-by: Gerda Shank <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Gerda Shank <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Gerda Shank <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Gerda Shank <[email protected]>
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Gerda Shank <[email protected]>
Resolves #
Problem
Solution
Checklist