Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 from various places #10861

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Remove Python 3.8 from various places #10861

merged 2 commits into from
Oct 16, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 16, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner October 16, 2024 15:05
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (d18f50b) to head (31f9a35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10861      +/-   ##
==========================================
- Coverage   89.19%   89.13%   -0.07%     
==========================================
  Files         183      183              
  Lines       23434    23434              
==========================================
- Hits        20903    20888      -15     
- Misses       2531     2546      +15     
Flag Coverage Δ
integration 86.41% <0.00%> (-0.16%) ⬇️
unit 62.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.12% <0.00%> (ø)
Integration Tests 86.41% <0.00%> (-0.16%) ⬇️

@gshank
Copy link
Contributor Author

gshank commented Oct 16, 2024

I don't see why "unit test / python 3.8" was trying to run.

@peterallenwebb
Copy link
Contributor

Ran the Tests and Code Checks pipeline successfully with these changes: https://github.com/dbt-labs/dbt-core/actions/runs/11371519059

@gshank
Copy link
Contributor Author

gshank commented Oct 16, 2024

It won't let us merge with that failing "unit test / python 3.8". Also I'm wondering if there's anything that needs to be done about codecov?

@peterallenwebb peterallenwebb merged commit 78c0571 into main Oct 16, 2024
52 of 56 checks passed
@peterallenwebb peterallenwebb deleted the remove_python_3.8 branch October 16, 2024 19:15
peterallenwebb added a commit that referenced this pull request Oct 16, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 16, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 16, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 16, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 16, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 18, 2024
* Remove Python 3.8 from various places (#10861)

* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>

* Revise test to reflect change in dbt-common

* Add another unit test.

---------

Co-authored-by: Gerda Shank <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 18, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Gerda Shank <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 18, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Gerda Shank <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 18, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Gerda Shank <[email protected]>
peterallenwebb added a commit that referenced this pull request Oct 18, 2024
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Gerda Shank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants