Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.latest] Pin dbt-common to <1.11.0 #10860

Closed
wants to merge 2 commits into from
Closed

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 16, 2024

Problem

In 1.8 we need to pin dbt-common because of incompatibility with new features

Solution

Pin dbt-common to < 1.11.0

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Oct 16, 2024
@gshank gshank requested a review from a team as a code owner October 16, 2024 13:02
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (924ce2d) to head (882a6e4).
Report is 2 commits behind head on 1.8.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10860      +/-   ##
==============================================
- Coverage       88.33%   88.27%   -0.06%     
==============================================
  Files             181      181              
  Lines           22796    22796              
==============================================
- Hits            20136    20123      -13     
- Misses           2660     2673      +13     
Flag Coverage Δ
integration 85.45% <ø> (-0.15%) ⬇️
unit 62.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank closed this Oct 17, 2024
@gshank gshank reopened this Oct 17, 2024
@gshank gshank closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant