-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy-First] Fix node_status
for hooks
#10845
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10845 +/- ##
==========================================
- Coverage 89.18% 89.12% -0.06%
==========================================
Files 183 183
Lines 23426 23430 +4
==========================================
- Hits 20893 20883 -10
- Misses 2533 2547 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
node_status
for hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Problem
There's a discrepancy for hooks in
run_results.json
:result.node.node_info["node_status"]
for hooks never changes fromstarted
result.status
contains the actual run status for a nodeThis is causing the dbt Cloud IDE to report the wrong status to users.
Solution
result.node.node_info["node_status"]
at the end of hook node runChecklist