Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better typing in jinja_static.py #10835

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

peterallenwebb
Copy link
Contributor

Added type annotations. Cleaned up.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 8, 2024 20:56
@cla-bot cla-bot bot added the cla:yes label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb added Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes labels Oct 8, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (5db0b81) to head (7fe927c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10835      +/-   ##
==========================================
- Coverage   89.15%   89.15%   -0.01%     
==========================================
  Files         183      183              
  Lines       23418    23422       +4     
==========================================
+ Hits        20878    20881       +3     
- Misses       2540     2541       +1     
Flag Coverage Δ
integration 86.37% <91.66%> (-0.01%) ⬇️
unit 62.11% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.11% <66.66%> (+<0.01%) ⬆️
Integration Tests 86.37% <91.66%> (-0.01%) ⬇️

@peterallenwebb peterallenwebb merged commit 40c350f into main Oct 11, 2024
61 of 62 checks passed
@peterallenwebb peterallenwebb deleted the paw/jinja-static-typing branch October 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants