Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy_first] Set default for STATE_MODIFIED_COMPARE_VARS flag, mark TestProjInfo as not a test class #10805

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 1, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke requested review from emmyoop, gshank and QMalcolm October 1, 2024 16:07
@aranke aranke marked this pull request as ready for review October 1, 2024 16:07
@aranke aranke requested a review from a team as a code owner October 1, 2024 16:07
@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (5e9f1b5) to head (28a381f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10805      +/-   ##
==========================================
- Coverage   89.22%   89.17%   -0.06%     
==========================================
  Files         183      183              
  Lines       23456    23457       +1     
==========================================
- Hits        20929    20917      -12     
- Misses       2527     2540      +13     
Flag Coverage Δ
integration 86.41% <100.00%> (-0.14%) ⬇️
unit 62.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.09% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.41% <100.00%> (-0.14%) ⬇️

@aranke aranke merged commit 75a0962 into main Oct 1, 2024
75 of 79 checks passed
@aranke aranke deleted the hotfix_oct_1 branch October 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants