Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '--inline-direct' parameter to 'dbt show'. #10770

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Sep 24, 2024

resolves #10778

Problem

The 'dbt show' command loaded the manifest and ran jinja templating, even when these steps were not needed.

Solution

Add a new "--inline-direct" parameter to skip the manifest load and templating steps.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • [] This PR includes type annotations for new and modified functions.

@peterallenwebb peterallenwebb requested a review from a team as a code owner September 24, 2024 19:24
@cla-bot cla-bot bot added the cla:yes label Sep 24, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (a8d4ba2) to head (9b0de70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10770      +/-   ##
==========================================
+ Coverage   88.99%   89.01%   +0.01%     
==========================================
  Files         181      181              
  Lines       23059    23115      +56     
==========================================
+ Hits        20521    20575      +54     
- Misses       2538     2540       +2     
Flag Coverage Δ
integration 86.20% <94.73%> (+0.02%) ⬆️
unit 62.21% <15.78%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.21% <15.78%> (-0.13%) ⬇️
Integration Tests 86.20% <94.73%> (+0.02%) ⬆️

@peterallenwebb
Copy link
Contributor Author

Note that I have disabled several type checks because we need to make several changes to AdapterProtocol before types in this changeset can be adequately annotated.

core/dbt/cli/main.py Outdated Show resolved Hide resolved
Co-authored-by: Doug Beatty <[email protected]>
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a failure test case too, otherwise LGTM!

@peterallenwebb peterallenwebb merged commit 359a2c0 into main Sep 25, 2024
65 of 66 checks passed
@peterallenwebb peterallenwebb deleted the paw/show-inline-direct branch September 25, 2024 16:31
@dichenqiandbt
Copy link

dichenqiandbt commented Sep 25, 2024

Thank you Peter for doing this! Exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a --inline-direct flag for dbt show
5 participants