-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '--inline-direct' parameter to 'dbt show'. #10770
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10770 +/- ##
==========================================
+ Coverage 88.99% 89.01% +0.01%
==========================================
Files 181 181
Lines 23059 23115 +56
==========================================
+ Hits 20521 20575 +54
- Misses 2538 2540 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Note that I have disabled several type checks because we need to make several changes to AdapterProtocol before types in this changeset can be adequately annotated. |
Co-authored-by: Doug Beatty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a failure test case too, otherwise LGTM!
Thank you Peter for doing this! Exciting! |
resolves #10778
Problem
The 'dbt show' command loaded the manifest and ran jinja templating, even when these steps were not needed.
Solution
Add a new "--inline-direct" parameter to skip the manifest load and templating steps.
Checklist