Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changelog entry #10765

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add missing changelog entry #10765

merged 2 commits into from
Sep 26, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 23, 2024

Resolves N/A

Problem

#10290 (comment) and #10290 (comment)

Solution

Manually add the relevant changelog entry for #10290.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • Tests are not required or relevant for this PR.
  • This PR has no interface changes.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (b4aba0d) to head (87ad184).
Report is 1 commits behind head on 1.8.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #10765      +/-   ##
==============================================
- Coverage       88.32%   88.27%   -0.05%     
==============================================
  Files             181      181              
  Lines           22796    22796              
==============================================
- Hits            20134    20123      -11     
- Misses           2662     2673      +11     
Flag Coverage Δ
integration 85.45% <ø> (-0.13%) ⬇️
unit 62.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10 dbeatty10 marked this pull request as ready for review September 23, 2024 21:49
@dbeatty10 dbeatty10 requested a review from a team as a code owner September 23, 2024 21:49
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dbeatty10 dbeatty10 merged commit 69f9212 into 1.8.latest Sep 26, 2024
60 of 62 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty10-patch-1 branch September 26, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants