Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy first] delete extraneous EventCatcher #10710

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 13, 2024

Resolves #N/A

Problem

We had two EventCatchers!!

Solution

Thankfully the older one (no predicate support) was not even being used, so I just ripped it out.
Confirmed no usage in dbt-adapters: https://github.com/search?q=repo%3Adbt-labs%2Fdbt-adapters%20EventCatcher&type=code

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 13, 2024
@MichelleArk MichelleArk added tidy_first "Tidy First" incremental cleanup changes and removed cla:yes labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (cc8541c) to head (a0b3a7f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10710   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         180      180           
  Lines       22842    22842           
=======================================
  Hits        20305    20305           
  Misses       2537     2537           
Flag Coverage Δ
integration 86.09% <ø> (ø)
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.09% <ø> (ø)

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Sep 13, 2024
@MichelleArk MichelleArk marked this pull request as ready for review September 13, 2024 20:35
@MichelleArk MichelleArk requested a review from a team as a code owner September 13, 2024 20:35
@MichelleArk MichelleArk merged commit 139b9ac into main Sep 13, 2024
72 checks passed
@MichelleArk MichelleArk deleted the tidy-event-catcher branch September 13, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants