Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] Fix the semicolon semantics for indexes while respecting other bug fix #10194

Merged
merged 4 commits into from
May 21, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare self-assigned this May 21, 2024
@mikealfare mikealfare requested review from a team as code owners May 21, 2024 16:04
@mikealfare mikealfare requested review from heysweet and removed request for a team May 21, 2024 16:04
@cla-bot cla-bot bot added the cla:yes label May 21, 2024
@mikealfare mikealfare changed the base branch from main to 1.7.latest May 21, 2024 16:04
@mikealfare mikealfare linked an issue May 21, 2024 that may be closed by this pull request
2 tasks
@mikealfare mikealfare assigned VersusFacit and unassigned mikealfare May 21, 2024
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikealfare! Approving this backport, pending all tests passing

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (d0ddeea) to head (626ab12).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest   #10194      +/-   ##
==============================================
+ Coverage       86.64%   86.67%   +0.02%     
==============================================
  Files             179      179              
  Lines           26722    26722              
==============================================
+ Hits            23153    23161       +8     
+ Misses           3569     3561       -8     
Flag Coverage Δ
integration 83.58% <ø> (+0.09%) ⬆️
unit 65.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare
Copy link
Contributor Author

Given this PR amounts to moving semicolons around in jinja and adding a test, that the error on the Artifact Schema Check appears to be a permissions error, and that the failed check is also not required, I am going to merge acknowledging and accepting the failed check.

@mikealfare mikealfare merged commit 879ae14 into 1.7.latest May 21, 2024
61 of 62 checks passed
@mikealfare mikealfare deleted the backport/1.7.latest/postgres-97 branch May 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Materialized view with multiple indexes errors
4 participants