Skip to content

Commit

Permalink
Fix circular import (#11137)
Browse files Browse the repository at this point in the history
Co-authored-by: Doug Beatty <[email protected]>
  • Loading branch information
dradetsky and dbeatty10 authored Dec 19, 2024
1 parent f2222d2 commit 95c090b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241211-132203.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix circular dependency
time: 2024-12-11T13:22:03.637443979-08:00
custom:
Author: dradetsky
Issue: 11142
1 change: 0 additions & 1 deletion core/dbt/cli/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from .main import cli as dbt_cli # noqa
10 changes: 1 addition & 9 deletions core/dbt/config/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Any, Dict, Optional, Tuple

from dbt.adapters.contracts.connection import Credentials, HasCredentials
from dbt.cli.resolvers import default_profiles_dir
from dbt.clients.yaml_helper import load_yaml_text
from dbt.contracts.project import ProfileConfig
from dbt.events.types import MissingProfileTarget
Expand Down Expand Up @@ -164,15 +165,6 @@ def pick_profile_name(
args_profile_name: Optional[str],
project_profile_name: Optional[str] = None,
) -> str:
# TODO: Duplicating this method as direct copy of the implementation in dbt.cli.resolvers
# dbt.cli.resolvers implementation can't be used because it causes a circular dependency.
# This should be removed and use a safe default access on the Flags module when
# https://github.com/dbt-labs/dbt-core/issues/6259 is closed.
def default_profiles_dir():
from pathlib import Path

return Path.cwd() if (Path.cwd() / "profiles.yml").exists() else Path.home() / ".dbt"

profile_name = project_profile_name
if args_profile_name is not None:
profile_name = args_profile_name
Expand Down

0 comments on commit 95c090b

Please sign in to comment.