Skip to content

Commit

Permalink
Fix typing issues with check_forcing_batch_concurrency
Browse files Browse the repository at this point in the history
  • Loading branch information
QMalcolm committed Dec 12, 2024
1 parent ed0f97a commit 5259718
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions core/dbt/parser/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1487,14 +1487,17 @@ def check_valid_microbatch_config(self):
if not has_input_with_event_time_config:
fire_event(MicrobatchModelNoEventTimeInputs(model_name=node.name))

def check_forcing_batch_concurrency(self):
def check_forcing_batch_concurrency(self) -> None:
if self.manifest.use_microbatch_batches(project_name=self.root_project.project_name):
adapter = get_adapter(self.root_project)

if not adapter.supports(Capability.MicrobatchConcurrency):
models_forcing_concurrent_batches = 0
for node in self.manifest.nodes.values():
if node.config.concurrent_batches is True:
if (
hasattr(node.config, "concurrent_batches")
and node.config.concurrent_batches is True
):
models_forcing_concurrent_batches += 1

Check warning on line 1501 in core/dbt/parser/manifest.py

View check run for this annotation

Codecov / codecov/patch

core/dbt/parser/manifest.py#L1501

Added line #L1501 was not covered by tests

if models_forcing_concurrent_batches > 0:
Expand Down

0 comments on commit 5259718

Please sign in to comment.