Skip to content

Commit

Permalink
Fix test_backwards_compatible_versions test
Browse files Browse the repository at this point in the history
When we regenerated the v10 test manifest artifact, it started having
the `metricflow_time_sine` model, and it didn't previously. This caused
`test_backwards_compatible_versions` to start failing because it was
no longer identified as having modified state for v10. The test has
been altered accordingly
  • Loading branch information
QMalcolm committed Oct 11, 2023
1 parent 3861a21 commit 3e6cd21
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/functional/artifacts/test_previous_version_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,10 @@ def test_compare_state_current(self, project):

def test_backwards_compatible_versions(self, project):
# manifest schema version 4 and greater should always be forward compatible
for schema_version in range(4, self.CURRENT_EXPECTED_MANIFEST_VERSION):
for schema_version in range(4, 10):
self.compare_previous_state(project, schema_version, True, 1)
for schema_version in range(10, self.CURRENT_EXPECTED_MANIFEST_VERSION):
self.compare_previous_state(project, schema_version, True, 0)

def test_nonbackwards_compatible_versions(self, project):
# schema versions 1, 2, 3 are all not forward compatible
Expand Down

0 comments on commit 3e6cd21

Please sign in to comment.